Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventEmitter: add EventEmitter#once(event[], ...) #779

Merged
merged 1 commit into from
Jul 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion common/lib/util/eventemitter.js
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,16 @@ var EventEmitter = (function() {
} else if(Utils.isEmptyArg(event)) {
this.anyOnce.push(listener);
} else if(Utils.isArray(event)){
throw("Arrays of events can only be used with on(), not once()");
var listenerWrapper = function() {
var args = Array.prototype.slice.call(arguments);
Utils.arrForEach(event, function(ev) {
self.off(ev, listenerWrapper);
});
listener.apply(this, args);
};
Utils.arrForEach(event, function(ev) {
self.on(ev, listenerWrapper);
});
} else {
var listeners = (this.eventsOnce[event] || (this.eventsOnce[event] = []));
listeners.push(listener);
Expand Down
25 changes: 25 additions & 0 deletions spec/realtime/event_emitter.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,31 @@ define(['shared_helper', 'chai'], function (helper, chai) {
closeAndFinish(done, realtime);
});

it('arrayOfEventsWithOnce', function (done) {
var realtime = helper.AblyRealtime({ autoConnect: false }),
callbackCalled = 0,
eventEmitter = realtime.connection;

var callback = function (arg) {
callbackCalled += 1;
expect(arg).to.equal('expected');
};

try {
callbackCalled = 0;
eventEmitter.once(['a', 'b', 'c'], callback);
eventEmitter.emit('a', 'expected');
eventEmitter.emit('b', 'wrong');
eventEmitter.emit('c', 'wrong');
expect(callbackCalled).to.equal(1, 'listener called back only once, for the first event emitted');
} catch (err) {
closeAndFinish(done, realtime, err);
return;
}

closeAndFinish(done, realtime);
});

/* check that listeners added in a listener cb are not called during that
* emit instance */
it('listenerAddedInListenerCb', function (done) {
Expand Down