-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert lib/types dir to TypeScript #794
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In an ideal world I would have liked to see new API commentary alongside at least some of the modules, types and methods/functions. This could be an opportunity to inject some of that, though I recognise it may not have been a priority for you.
I'm also noticing a lot of variance in terms of indentation. e.g. common/lib/types/stats.ts
vs common/lib/util/dataSizeBytes.ts
. I've not pulled the code in locally to inspect further but the impression is that some files are using tabs and others using spaces. I assume, therefore, that we're not running any tools over the code in CI that would spot for formatting inconsistencies? I think we should be and these tools should form foundational underpinnings to this work - otherwise we're only going to need to go back over all the files again some time in the future to conform them.
@QuintinWillison The tabs vs spaces stuff should be fixed now. As for the API commentary that would go on the external type interface ( |
Resolves #790