Improve checks for XHRRequest error responses #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/804/bundle-report
owenpearson
changed the title
github-actions
bot
temporarily deployed
to
staging/pull/804/bundle-report
QuintinWillison
suggested changes
Oct 2, 2021
SimonWoolf
requested changes
Oct 4, 2021
QuintinWillison
approved these changes
Oct 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some parts of the realtime app use X-Ably-ErrorCode instead of x-ably-errorcode for some reason which was causing problems in some of the browser tests.
Also partial errors from batch requests don't have the header at all so this PR adds a check for the 40020 error code.