Add typings for ClientOptions #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
temporarily deployed
to
staging/pull/854/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/854/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/854/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/854/bundle-report
github-actions
bot
temporarily deployed
to
staging/pull/854/bundle-report
ikbalkaya
previously requested changes
Nov 18, 2021
There was a problem hiding this comment.
I realised lots of usage of optional properties in this PR. I think they make things flexible but also make code a bit more vulnerable. (correct me if this is not the case in Javascript) my understanding of optional usage is that they should be used with a purpose and choosing them is part of design of the app. For example, by design the autoconnect property is intended to be true by default, but making it optional you declare it so that it may not even exist. I hope that is helpful.
QuintinWillison
suggested changes
Nov 22, 2021
QuintinWillison
approved these changes
Nov 29, 2021
QuintinWillison
dismissed
ikbalkaya’s stale review
Comments have been addressed and this reviewer is not available today to approve for themselves.
Base automatically changed from
feature/channel-typescript
to
integration/typescript
December 1, 2021 12:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.