-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typings for ClientOptions #854
Add typings for ClientOptions #854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realised lots of usage of optional properties in this PR. I think they make things flexible but also make code a bit more vulnerable. (correct me if this is not the case in Javascript) my understanding of optional usage is that they should be used with a purpose and choosing them is part of design of the app. For example, by design the autoconnect property is intended to be true by default, but making it optional you declare it so that it may not even exist. I hope that is helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I acknowledge that it's perhaps unrealistic to try to add API commentary to every type as part of the JS to TS conversion, however I think new types should be easy to document now.
Comments have been addressed and this reviewer is not available today to approve for themselves.
No description provided.