Add grunt release:[releasetype] task #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but how has this been tested? |
|
By me trying it locally - it doesn't push anything or use ably-env at all, just creates the commit, so easy enough to try out and revert (don't forget to delete the new tag it creates, removing the commit it points to doesn't do that) |
|
/cc @mattheworiordan any comments? |
| "karma-chrome-launcher": "~0.1", | ||
| "karma-firefox-launcher": "~0.1", |
There was a problem hiding this comment.
It wasn't. It was moved down to line 32, karma-nodeunit was moved from 35 to 33, karma-cli from 27 to 30. npm sorts the array into alphabetical order automatically. Presumably it had got out of alphabetical order due to entries being manually added
There was a problem hiding this comment.
Ah yes, sorry, reviewed in haste
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
grunt release:patchto increment the patch level, compile everything, commit the generated files, and tag that commit with the release version.Can also use
minor,major,prepatch,prereleaseetc. instead ofpatch.