Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tie internal and external typings together #890

Merged
merged 7 commits into from
Feb 23, 2022
Merged

Tie internal and external typings together #890

merged 7 commits into from
Feb 23, 2022

Conversation

Peter-Maguire
Copy link
Contributor

Resolves #857

Internal types now extend public types where appropriate, and use the public type if there is no difference.

@Peter-Maguire Peter-Maguire self-assigned this Feb 15, 2022
@Peter-Maguire
Copy link
Contributor Author

There's some bits here where I had to change null to undefined to comply with the typings, I don't think they will cause problems, but it might be worth taking a look at them to make sure I'm not missing any reason why they might.

@github-actions github-actions bot temporarily deployed to staging/pull/890/bundle-report February 15, 2022 14:07 Inactive
owenpearson
owenpearson requested changes Feb 15, 2022
View reviewed changes
common/lib/client/auth.ts Outdated Show resolved Hide resolved
ably.d.ts Outdated Show resolved Hide resolved
common/lib/client/auth.ts Outdated Show resolved Hide resolved
common/lib/client/auth.ts Show resolved Hide resolved
common/types/channel.d.ts Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to staging/pull/890/bundle-report February 16, 2022 11:04 Inactive
owenpearson
owenpearson approved these changes Feb 23, 2022
View reviewed changes
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peter-Maguire Peter-Maguire merged commit 8e3ae21 into integration/typescript Feb 23, 2022
@Peter-Maguire Peter-Maguire deleted the use-public-typescript-typings branch February 23, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owenpearson owenpearson owenpearson approved these changes

Assignees

@Peter-Maguire Peter-Maguire

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peter-Maguire @owenpearson