Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel status #159

Merged
merged 11 commits into from
May 30, 2022
Merged

Channel status #159

merged 11 commits into from
May 30, 2022

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented May 24, 2022

@sacOO7 sacOO7 requested a review from owenpearson May 25, 2022 11:57
@sacOO7 sacOO7 marked this pull request as ready for review May 25, 2022 11:57
@sacOO7 sacOO7 force-pushed the feature/RSL8-channel-status branch from 8d549cc to 13fccaf Compare May 25, 2022 12:01
@sacOO7 sacOO7 requested a review from ikbalkaya May 27, 2022 12:42
Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🙂 just a couple of small comments

tests/ChannelStatusTest.php Outdated Show resolved Hide resolved
tests/ChannelStatusTest.php Outdated Show resolved Hide resolved
@sacOO7 sacOO7 requested a review from owenpearson May 28, 2022 04:50
Copy link

@ikbalkaya ikbalkaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Member

@owenpearson owenpearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@owenpearson owenpearson merged commit 15b0d83 into main May 30, 2022
@owenpearson owenpearson deleted the feature/RSL8-channel-status branch May 30, 2022 11:46
@AmirQSD AmirQSD mentioned this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add support to get channel lifecycle status
3 participants