Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RSL1g duplicate #415

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Fix RSL1g duplicate #415

merged 1 commit into from
Apr 13, 2018

Conversation

funkyboy
Copy link
Contributor

No description provided.

Copy link
Member

@paddybyers paddybyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all references to this updated, eg in the spreadsheet and library repos?

@funkyboy
Copy link
Contributor Author

This is to prevent duplicates in the spreadsheet, so I’ll update it after this is merged.

BUT, I didn’t think of repos.
Do you have in mind a less disruptive relabeling that doesn’t require to update/check all the repos?

@paddybyers
Copy link
Member

Do you have in mind a less disruptive relabeling that doesn’t require to update/check all the repos?

no :(

@funkyboy
Copy link
Contributor Author

@paddybyers
Copy link
Member

that doesn’t require to update/check all the repos?

If this is a new requirement being added for 1.1 then you only need to check ably-js because none of the others will have been updated.

@funkyboy
Copy link
Contributor Author

@paddybyers Lastly, AFAICT ably-js doesn't perform any check on the message size, right @SimonWoolf?
There's just a check on the size of token requests: https://github.com/ably/ably-js/blob/master/common/lib/client/auth.js#L428

@SimonWoolf
Copy link
Member

Lastly, AFAICT ably-js doesn't perform any check on the message size, right @SimonWoolf?

not yet, it's a todo for 1.1

Copy link
Member

@mattheworiordan mattheworiordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this needs approval as pretty clear it needs correcting! Thansk for identifying and resolving. :)

@funkyboy funkyboy merged commit 6a4b90c into master-1-1 Apr 13, 2018
@funkyboy funkyboy deleted the fix-duplicate-label branch April 13, 2018 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants