-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RSL1g duplicate #415
Fix RSL1g duplicate #415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all references to this updated, eg in the spreadsheet and library repos?
This is to prevent duplicates in the spreadsheet, so I’ll update it after this is merged. BUT, I didn’t think of repos. |
no :( |
@paddybyers actually this shouldn't be a problem because it is a new item. See https://github.com/ably/docs/compare/v1.0...master-1-1?diff=split&name=master-1-1#diff-11900b395df266bc2bbfc1d11bdfc7a0R204 |
If this is a new requirement being added for 1.1 then you only need to check ably-js because none of the others will have been updated. |
@paddybyers Lastly, AFAICT ably-js doesn't perform any check on the message size, right @SimonWoolf? |
not yet, it's a todo for 1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this needs approval as pretty clear it needs correcting! Thansk for identifying and resolving. :)
No description provided.