Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak cipherparams description, add getDefaultParams #43

Merged
merged 1 commit into from
Sep 9, 2015
Merged

Tweak cipherparams description, add getDefaultParams #43

merged 1 commit into from
Sep 9, 2015

Conversation

SimonWoolf
Copy link
Member

discussion in ably/ably-js#120

@SimonWoolf SimonWoolf mentioned this pull request Sep 8, 2015
Merged
@mattheworiordan
Copy link
Member

👍 merge away unless @paddybyers objects

@paddybyers
Copy link
Member

The default keyLength is not 128; each algorithm has its own range of possible values and default. I suggest:

@(TZ2b)@ @keyLength@ integer - An integer, from an algorithm-dependent range of possible values. If unspecified, an algorithm-dependent default is used. For AES the allowed values at least include 128 and 256, with a default of 128.

@paddybyers
Copy link
Member

Other than that, lgtm

SimonWoolf added a commit that referenced this pull request Sep 9, 2015
@SimonWoolf
Merge pull request #43 from ably/get-default-params
dd19895 
Tweak cipherparams description, add getDefaultParams
@SimonWoolf SimonWoolf merged commit dd19895 into source Sep 9, 2015
@SimonWoolf
Copy link
Member Author

Merged with Paddy's change

@mattheworiordan mattheworiordan deleted the get-default-params branch September 29, 2015 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonWoolf @mattheworiordan @paddybyers