counsel.el (counsel-locate-action-extern): Refactor #1401
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use start-process-shell-command which already calls call-process with shell-file-name.
|
Thanks. |
abo-abo
pushed a commit
that referenced
this pull request
Sep 19, 2018
`start-process-shell-command` doesn't seem to wait for `counsel-locate-action-extern` to finish under Ubuntu. [Gist to reproduce the issue](https://gist.github.com/yiufung/38be4c3a6832334f36f2441550cf0b12). Related discussion: ([#1](https://askubuntu.com/questions/646631/emacs-doesnot-work-with-xdg-open), [#2](https://emacs.stackexchange.com/questions/19344/why-does-xdg-open-not-work-in-eshell), [#3](http://emacs.1067599.n8.nabble.com/emacs-and-xdg-open-td106892.html)) suggests to: 1. Set `process-connection-type` as nil temporarily 2. Called with `setsid -w` to wait for the process to finish. To avoid interfering with other platforms and applications, I adopted the latter approach which uses `lsb_release` to check distribution type with fall back as `xdg-open`. Currently only check for Ubuntu, and to be extended in the future. Re #863 Re #1401 Fixes #1759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use start-process-shell-command which already calls call-process with
shell-file-name.