Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to a detected package the list of files that it contains #1554

Closed
pombredanne opened this issue May 8, 2019 · 1 comment
Closed

Add to a detected package the list of files that it contains #1554

pombredanne opened this issue May 8, 2019 · 1 comment

Comments

@pombredanne
Copy link
Contributor

Description

Packages often contain other nested packages from other origins. For instance an installed npm-based application will have a node_modules directory of the provisioned dependencies once an npm install command has been issued. The same would apply to Pypi packages in a virtualenv, Rubygems bundled in a vendor dir with bundler, nested Maven projects... etc.

Therefore it would be useful to attach the list of files that are part of a detected package in the packages list of returned results. In many cases this list of files is exactly the same as the descendants files of the package root directory ... but not always as explained above.

The usage will be to use these to perform a proper summarization of the license/origin/etc of the files that are part of a package at the package level. And this will support #377

pombredanne added a commit that referenced this issue May 10, 2019
This is optional and not on by default.
Also removed Maven-only test code from base model

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne added a commit that referenced this issue May 10, 2019
This is an experiment to summarize package details for license and
copyright

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
JonoYang added a commit that referenced this issue Aug 2, 2019
    * Move get_package_resource to build packge superclass

Signed-off-by: Jono Yang <jyang@nexb.com>
@pombredanne
Copy link
Contributor Author

This is now handled in several tickets https://github.com/nexB/scancode-toolkit/labels/package-at-toplevel and in #2098

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant