Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--extract should not be an option but a separate command #52

Closed
pombredanne opened this issue Aug 7, 2015 · 2 comments
Closed

--extract should not be an option but a separate command #52

pombredanne opened this issue Aug 7, 2015 · 2 comments
Labels
archive extraction enhancement
Milestone
v1.4

Comments

@pombredanne
Copy link
Contributor

Extraction feels like a wart in the scancode command. It does not share any of the semantics of the command and should be best as a separate command such as extractcode that would only extract things.
@mjherzog
Copy link
Member

mjherzog commented Aug 7, 2015

I strongly agree. There are so many possible twists and turns for extraction so that it needs to be part of a scanning pipeline, but not deeply embedded in another step in the scanning pipeline.

pombredanne added a commit to pombredanne/scancode-toolkit that referenced this issue Aug 10, 2015
@pombredanne
Created new extractcode standlone command for aboutcode-org#52
e02fd29
pombredanne added a commit to pombredanne/scancode-toolkit that referenced this issue Aug 10, 2015
@pombredanne
Added --package scan option for aboutcode-org#44, removed --extract o…
a67f302 
…ption for aboutcode-org#52

 * --extract is now in the extractcode command for aboutcode-org#52
 * refactored the command code to sperate progress reporting from
   actual scan.
@pombredanne
Copy link
Contributor Author

This is fixed now

@jdaguil jdaguil modified the milestone: v1.4 Nov 24, 2015
pombredanne added a commit that referenced this issue Nov 24, 2015
@pombredanne @jdaguil
Created new extractcode standlone command for #52
2a38e29
pombredanne added a commit that referenced this issue Nov 24, 2015
@pombredanne @jdaguil
Added --package scan option for #44, removed --extract option for #52
47329fc 
 * --extract is now in the extractcode command for #52
 * refactored the command code to sperate progress reporting from
   actual scan.
pombredanne added a commit that referenced this issue Dec 7, 2015
@pombredanne
Revert "Added --package scan option for #44, removed --extract option…
b09f3b0 
… for #52"

This reverts commit 47329fc.
pombredanne added a commit that referenced this issue Dec 7, 2015
@pombredanne
Revert "Created new extractcode standlone command for #52"
9881e9e 
This reverts commit 2a38e29.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
archive extraction enhancement
Projects
None yet
Milestone
v1.4
Development

No branches or pull requests
3 participants
@pombredanne @jdaguil @mjherzog