Improve summary and score #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pombredanne
force-pushed
the
improve-summary-and-score
branch
from
44bb9aa
to
7440831
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1253 +/- ##
===========================================
+ Coverage 83.25% 84.23% +0.97%
===========================================
Files 118 118
Lines 13001 13180 +179
===========================================
+ Hits 10824 11102 +278
+ Misses 2177 2078 -99
Continue to review full report at Codecov.
|
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
* make the main loop simpler with configured scoring elements * add tests to license score computation * add support for future additional scoring elements Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
pombredanne
force-pushed
the
improve-summary-and-score
branch
from
7440831
to
f441d8d
Compare
|
All green. Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a set of improvements for #1180
This add an is_key_file as a file flag and improves the computation.
This also improves generated code detection for #377