Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base native plugins for Alpine linux #1284

Closed
wants to merge 6 commits into from
Closed

Conversation

pombredanne
Copy link
Contributor

This is to support #1262
For now these contain placeholder empty .so/.exe

Signed-off-by: Philippe Ombredanne pombredanne@nexb.com

@sschuberth
Copy link
Collaborator

Hmm. Creating an alpine sub-directory below plugins does not seem to match the current conventions. I would have expected this to create directories like

extractcode-7z-alpinelinux1_x86_64
extractcode-libarchive-alpinelinux1_x86_64
typecode-libmagic-alpinelinux1_x86_64

@pombredanne
Copy link
Contributor Author

@sschuberth since there is no support for now for linux distros in Wheels tags, this is a workaround: we will still be able to get pre-built for Alpine but they must use a name such as the one I use (note that this directory name does not matter much... what matter is the name inside setup.py AND the platform plat-name arg inside here https://github.com/nexB/scancode-toolkit/blob/88127230c2d12d8ede3f8e391e4b1157cf43ffb2/plugins/alpine/extractcode-7z-linux_x86_64/setup.cfg#L5 (which is wrong btw and should be instead linux_x86_64 since this is the tag for Alpine based on your comments)

In anycase, if and when distro will be supported in pip the tag will most likely be in the style of: linux_x86_64_alpine ... and not alpinelinux1_x86_64 as the distro would likely come last.

For now these contain placeholder empty .so/.exe

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #1284 into develop will increase coverage by 0.14%.
The diff coverage is 60%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1284      +/-   ##
===========================================
+ Coverage    84.11%   84.25%   +0.14%     
===========================================
  Files          118      118              
  Lines        13037    13041       +4     
===========================================
+ Hits         10966    10988      +22     
+ Misses        2071     2053      -18
Impacted Files Coverage Δ
src/commoncode/command.py 85.59% <100%> (ø) ⬆️
src/scancode/extract_cli.py 87.25% <50%> (+2.25%) ⬆️
src/scancode/cli.py 77.09% <50%> (+1.18%) ⬆️
src/scancode/api.py 96.29% <0%> (+1.48%) ⬆️
src/formattedcode/output_spdx.py 90.05% <0%> (+1.65%) ⬆️
src/packagedcode/plugin_package.py 92.3% <0%> (+1.92%) ⬆️
src/formattedcode/output_csv.py 86.8% <0%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d10ac...82bfd81. Read the comment docs.

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Removed unused packages and obsolete doc

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
@sschuberth
Copy link
Collaborator

Ok.

So by now it seems we have a bunch of not-strictly-Alpine-Linux-related cleanup commits in here. I don't have the background to judge all changes in-depth, but they look reasonable to me.

@steven-esser
Copy link
Contributor

@pombredanne Ping. Not sure if this is ready or not.

@pombredanne
Copy link
Contributor Author

Closing this for now.

  1. this is stale
  2. the whole set of native plugins would nee to be built from sources to tun on Alpine as there are dependencies on libc in these. https://github.com/nexB/scancode-plugins should help though

@pombredanne pombredanne deleted the 1262-alpine branch January 29, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants