Improve license clarity scoring #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
* Show boolean flags in scoring_elements to show what license judgement criteria was used Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
Signed-off-by: Jono Yang <jyang@nexb.com>
* If a package has conflicting or ambigous licenses and the score is already zero, do not subtract from the score Signed-off-by: Jono Yang <jyang@nexb.com>
* The classify plugin was determining the types of key files by checking the start or end of file names to see if they are a special type of file. However, the code checked the full filename with extension. This would cause us to not classify certain key files properly. Signed-off-by: Jono Yang <jyang@nexb.com>
* Fix logic in check_for_license_ambiguity
* Removed unused test file
Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
2861-license-clarity-update
branch
from
3e272a8
to
9a5bad6
Compare
* Add test for license ambiguity * Remove previous license clarity scoring plugin Signed-off-by: Jono Yang <jyang@nexb.com>
JonoYang
force-pushed
the
2861-license-clarity-update
branch
from
c9b366c
to
f998e21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves license clarity scoring as designed by @DennisClark in #2861
Tasks
Run tests locally to check for errors.