Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPM mariner package detection support #3734

Merged
merged 1 commit into from
May 6, 2024

Conversation

AyanSinhaMahapatra
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra commented Apr 10, 2024

Reference: aboutcode-org/scancode.io#1156

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

AyanSinhaMahapatra added a commit to aboutcode-org/scancode.io that referenced this pull request Apr 10, 2024
Reference: aboutcode-org/scancode-toolkit#3734
Reference: #1156

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks... juts a few and good to merge!

src/packagedcode/__init__.py Outdated Show resolved Hide resolved
src/packagedcode/rpm.py Outdated Show resolved Hide resolved
src/packagedcode/rpm.py Show resolved Hide resolved
src/packagedcode/rpm.py Show resolved Hide resolved
Reference: aboutcode-org/scancode.io#1156

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please merge.

@AyanSinhaMahapatra
Copy link
Member Author

Thanks, merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 9994223 into develop May 6, 2024
34 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the add-mariner-support branch May 6, 2024 11:01
AyanSinhaMahapatra added a commit to aboutcode-org/scancode.io that referenced this pull request May 8, 2024
Reference: aboutcode-org/scancode-toolkit#3734
Reference: #1156

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
AyanSinhaMahapatra added a commit to aboutcode-org/scancode.io that referenced this pull request Jul 18, 2024
Reference: aboutcode-org/scancode-toolkit#3734
Reference: #1156

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
tdruez pushed a commit to aboutcode-org/scancode.io that referenced this pull request Jul 19, 2024
Reference: aboutcode-org/scancode-toolkit#3734
Reference: #1156

Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants