Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention that in Fedora you can now install scancode from Fedora repo #3824

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

xsuchy
Copy link
Contributor

@xsuchy xsuchy commented Jun 24, 2024

See https://bodhi.fedoraproject.org/updates/?packages=scancode-toolkit

Fixes: #3095

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

@AyanSinhaMahapatra
Copy link
Contributor

Thanks a lot @xsuchy!
Could you also mention this in the installation docs at https://github.com/nexB/scancode-toolkit/blob/develop/docs/source/getting-started/install.rst?plain=1 so this shows up at https://scancode-toolkit.readthedocs.io/en/latest/getting-started/install.html

This would be a new section and reference here at https://github.com/nexB/scancode-toolkit/blob/develop/docs/source/getting-started/install.rst?plain=1#L414 and a reference at https://github.com/nexB/scancode-toolkit/blob/develop/docs/source/getting-started/install.rst?plain=1#L36, both like the pip install sections above.

@pombredanne
Copy link
Contributor

@xsuchy you rock 🚀

@xsuchy
Copy link
Contributor Author

xsuchy commented Jun 25, 2024

@xsuchy you rock 🚀

Nah. I did just a fraction of the work. Credits go to Eclipseo.

@xsuchy
Copy link
Contributor Author

xsuchy commented Jun 25, 2024

Thanks a lot @xsuchy! Could you also mention this in the installation docs

Updated.

Copy link
Contributor

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xsuchy Thanks!
We need just these tiny changes to highlight these correctly in the docs, and this is ready to merge otherwise.

docs/source/getting-started/install.rst Outdated Show resolved Hide resolved
docs/source/getting-started/install.rst Outdated Show resolved Hide resolved
xsuchy and others added 2 commits June 26, 2024 15:11
Co-authored-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Co-authored-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
@AyanSinhaMahapatra
Copy link
Contributor

Thanks! Merging this.

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit 9a6354d into aboutcode-org:develop Jun 26, 2024
3 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build RPMs for scancode
3 participants