Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Added workaround for testing on RedHat OSs #883

Merged

Conversation

nishakm
Copy link
Contributor

@nishakm nishakm commented Jan 11, 2018

Since Scancode binaries are built on Debian based machines, and the
prebuilt dependencies are named differently on RedHat based machines
py.test will not be able to find the libbz2.so library on those
machines.
See https://github.com/nexB/scancode-toolkit/issues/443

Added a note about how to work around this issue by symbolically
linking the existing libbz2.so on the filesystem to the expected
name.

This should be removed once
#469 is solved

Signed-off-by: Nisha K nishak@vmware.com

Since Scancode binaries are built on Debian based machines, and the
prebuilt dependencies are named differently on RedHat based machines
py.test will not be able to find the libbz2.so library on those
machines.
See https://github.com/nexB/scancode-toolkit/issues/443

Added a note about how to work around this issue by symbolically
linking the existing libbz2.so on the filesystem to the expected
name.

This should be removed once
aboutcode-org#469 is solved

Signed-off-by: Nisha K <nishak@vmware.com>
@codecov
Copy link

codecov bot commented Jan 12, 2018

Codecov Report

Merging #883 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #883      +/-   ##
===========================================
+ Coverage    79.06%   79.08%   +0.01%     
===========================================
  Files           93       93              
  Lines        11456    11456              
===========================================
+ Hits          9058     9060       +2     
+ Misses        2398     2396       -2
Impacted Files Coverage Δ
src/scancode/api.py 77.24% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a908319...de4d2de. Read the comment docs.

@nishakm
Copy link
Contributor Author

nishakm commented Jan 12, 2018

@pombredanne can you review this?

Questions I have about this PR:

  1. Do I need to add my name to AUTHORS.rst?
  2. Where do I put results from py.test? (This is just a change in docs so I am not sure if this is necessary for this PR)
  3. Do I need to add something about this change in CHANGELOG.rst?

Thanks!

@pombredanne
Copy link
Contributor

Thanks. And sorry for the delay

Do I need to add my name to AUTHORS.rst?

Sure thing. This is a small PR though, so your call

Where do I put results from py.test? (This is just a change in docs so I am not sure if this is necessary for this PR)

They are run automatically as you can see above

Do I need to add something about this change in CHANGELOG.rst?

not for a small change like this

@pombredanne
Copy link
Contributor

LGTM. Merging!

@pombredanne
Copy link
Contributor

Thanks again.

@pombredanne pombredanne merged commit d53aac8 into aboutcode-org:develop Jan 19, 2018
@nishakm nishakm deleted the docs-redhat-os-test-workaround branch January 19, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants