Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete modal close button not working and cancel button working as delete #116

Closed
sagarsangwan opened this issue Mar 23, 2021 · 2 comments
Closed

Delete modal close button not working and cancel button working as delete #116

sagarsangwan opened this issue Mar 23, 2021 · 2 comments
Assignees
@tdruez
Labels
bug Something isn't working
Milestone
2021-05

Comments

@sagarsangwan
Copy link

Steps to reproduce -

  1. Go to scanpipe project details page "/project/<PROJECT_ID>"
  2. Press delete/trash button below project name.
  3. ISSUE 1 - Try closing modal using close button. It doesn't work.
  4. ISSUE 2 - Press "No, Cancel". It deletes the project.
@sagarsangwan
Copy link
Author

Issue fixed in this PR #115

@tdruez tdruez added this to the 2021-05 milestone Apr 7, 2021
@tdruez tdruez added the bug Something isn't working label Apr 7, 2021
@tdruez tdruez self-assigned this Apr 7, 2021
tdruez added a commit that referenced this issue Apr 9, 2021
@tdruez
Fix close and cancel buttons modals #116 #141
2b31db6 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
@tdruez
Copy link
Contributor

tdruez commented Apr 9, 2021

@sagarsangwan thanks for reporting those issues and for providing a PR. Much appreciated.
See 2b31db6 for a solution that does not require inline JS.

@tdruez tdruez closed this as completed Apr 9, 2021
tdruez added a commit that referenced this issue Apr 9, 2021
@tdruez
Add changelog entry #116 #141
8077ceb 
Signed-off-by: Thomas Druez <tdruez@nexb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdruez tdruez

Labels
bug Something isn't working
Projects
None yet
Milestone
2021-05
Development

No branches or pull requests
2 participants
@tdruez @sagarsangwan