-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do no use subprocess for the ScanPackage (scan_package) pipeline #798
Comments
tdruez
added a commit
that referenced
this issue
Aug 10, 2023
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez
added a commit
that referenced
this issue
Aug 11, 2023
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez
added a commit
that referenced
this issue
Aug 11, 2023
Signed-off-by: Thomas Druez <tdruez@nexb.com>
tdruez
added a commit
that referenced
this issue
Aug 11, 2023
Signed-off-by: Thomas Druez <tdruez@nexb.com>
Following the merge of #855 , we are not relying on a subprocess call anymore as we call directly the This is better but there's still the following limitations:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using subprocess is problematic for multiple reasons:
mock
in the unit test contextstatus
system to flag and exclude resources from scanFrom #556 (comment)
The 2 missing pieces as callable API for the ScanPackage pipeline are:
--classify
: FileClassifier(PostScanPlugin)--summary
: ScanSummary(PostScanPlugin)The text was updated successfully, but these errors were encountered: