Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown distro errors should be more explicit #97

Closed
pombredanne opened this issue Feb 13, 2021 · 1 comment
Closed

Unknown distro errors should be more explicit #97

pombredanne opened this issue Feb 13, 2021 · 1 comment

Comments

@pombredanne
Copy link
Member

We want to support and id many distros. For now if we cannot recognize one we get this:

Error during scanpipe/pipelines/root_filesystems.py execution:

'NoneType' object has no attribute 'to_dict'

Traceback:
  File "/home/work/scancode.io/scanpipe/pipelines/__init__.py", line 75, in execute
    step(self)
  File "/home/work/scancode.io/scanpipe/pipelines/root_filesystems.py", line 50, in collect_rootfs_information
    rootfs_data["distro"] = rfs.distro.to_dict()

We should instead provide at least a better error message:

  1. outline the checks that were made (e.g. searching for specific files that were not found)
  2. provide a link to doc and request to report a bug

This may be something to implement in https://github.com/nexB/container-inspector/blob/develop/src/container_inspector/distro.py partially

tdruez added a commit that referenced this issue Feb 15, 2021
- Improve support for unknown distros in docker and root_filesystem pipelines #97

Signed-off-by: Thomas Druez <tdruez@nexb.com>
@tdruez
Copy link
Contributor

tdruez commented Feb 15, 2021

Fixed in eb970db

@tdruez tdruez closed this as completed Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants