Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for vulnerablecode integration #626

Merged
merged 6 commits into from
Mar 3, 2023
Merged

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Mar 1, 2023

No description provided.

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@tdruez
Copy link
Contributor

tdruez commented Mar 2, 2023

@TG1999 Could you add an introduction paragraph about the context of this integration.
You added the "how" but we also need the "why".

Also, a section about the usage of the find_vulnerabilities pipeline would be useful, following the configuration parts.

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Copy link
Contributor Author

TG1999 commented Mar 2, 2023

@tdruez done!

@tdruez
Copy link
Contributor

tdruez commented Mar 2, 2023

It would be more interesting to display screenshots about the actual vulnerability results of running the pipeline instead of showing how to add and run a pipeline, which is already cover in other tutorial.

For example:
Screenshot 2023-03-02 at 13 59 57
Screenshot 2023-03-02 at 14 00 16

and so on.

@tdruez tdruez mentioned this pull request Mar 2, 2023
4 tasks
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Copy link
Contributor Author

TG1999 commented Mar 2, 2023

@tdruez done!

Signed-off-by: Thomas Druez <tdruez@nexb.com>
Signed-off-by: Thomas Druez <tdruez@nexb.com>
Signed-off-by: Thomas Druez <tdruez@nexb.com>
@tdruez tdruez merged commit e309536 into main Mar 3, 2023
@tdruez tdruez deleted the vcio_integration branch March 3, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants