Add CWE support in all importers #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ziadhany
changed the title
TG1999
requested changes
Nov 10, 2023
vulnerabilities/importers/github.py
Outdated
| @@ -227,10 +233,18 @@ def process_response(resp: dict, package_type: str) -> Iterable[AdvisoryData]: | |||
| else: | |||
| logger.error(f"Unknown identifier type {identifier_type!r} and value {value!r}") | |||
|
|
|||
| weaknesses = [] | |||
There was a problem hiding this comment.
Please make a separate function get_cwes_from_github_advisory and add docstring and tests for that.
ziadhany
force-pushed
the
cwe-importers
branch
from
84e191d
to
c7c4f76
Compare
ziadhany
commented
Nov 14, 2023
| try: | ||
| db.get(cwe_id) | ||
| weaknesses.append(cwe_id) | ||
| except Exception: |
There was a problem hiding this comment.
we should change this general exception and replace it with ( InvalidCWEError ) after we merge this aboutcode-org/cwe2#10
Add get_cwes_from_github_advisory function and a test Add CWE support for github importer Add CWE support for osv Add CWE support for gitlab and redhat Signed-off-by: ziadhany <ziadhany2016@gmail.com>
TG1999
force-pushed
the
cwe-importers
branch
from
c7c4f76
to
6158b2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issues: #1093