Fix empty version range crash #1215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janniclas
force-pushed
the
f-fixVersionRange
branch
from
f233247 to
f801149
Compare
|
@janniclas thanks for this PR, if you can add some tests to highlight the issues which are fixed by this PR it would be really helpful. |
|
Sure, I'll look into it soonish |
Signed-off-by: Jan-Niclas Struewer <j.n.struewer@gmail.com>
Signed-off-by: Jan-Niclas Struewer <j.n.struewer@gmail.com>
…ck, as this call can fail due the affected_package to be None. Signed-off-by: Jan-Niclas Struewer <j.n.struewer@gmail.com>
Signed-off-by: Jan-Niclas Struewer <j.n.struewer@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com> Signed-off-by: Jan-Niclas Struewer <j.n.struewer@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com> Signed-off-by: Jan-Niclas Struewer <j.n.struewer@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com> Signed-off-by: Jan-Niclas Struewer <j.n.struewer@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com> Signed-off-by: Jan-Niclas Struewer <j.n.struewer@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com> Signed-off-by: Jan-Niclas Struewer <j.n.struewer@gmail.com>
…anges Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com> Signed-off-by: Jan-Niclas Struewer <j.n.struewer@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com> Signed-off-by: Jan-Niclas Struewer <j.n.struewer@gmail.com>
Signed-off-by: Jan-Niclas Struewer <j.n.struewer@gmail.com>
janniclas
force-pushed
the
f-fixVersionRange
branch
from
b9677c8 to
faac7ee
Compare
|
@TG1999 I added a test case based upon the original input I got when running the vulnerabilities.importers.apache_httpd.ApacheHTTPDImporter . |
|
@janniclas sorry for late reply, please resolve the merge conflicts : ) |
Merged
|
@janniclas I am closing this in favor of #1598 with a fixed history and your commits squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the issue reported in #1214 .
I'm not familiar with either this project nor python, so I'm unsure if this is a good solution. However, it solved the issue I described in the linked ticket. Feedback welcome!