-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark advisories status according to NVD advisory #1232
Conversation
8266076
to
00639d3
Compare
vulnerabilities/models.py
Outdated
class VulnerabilityStatusType(models.IntegerChoices): | ||
"""List of vulnerability statuses.""" | ||
|
||
PUBLISHED = 1, "published" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code in https://github.com/nexB/vulnerablecode/pull/1232/files#diff-3e8fc96d993d0bd8585642f68239732a30a19b7ec100a36ee5d21e209625ff81R120 seem redundant. Could we have a single label, either as "published" or "Published" but not both?
vulnerabilities/views.py
Outdated
@@ -115,12 +115,21 @@ class VulnerabilityDetails(DetailView): | |||
def get_queryset(self): | |||
return super().get_queryset().prefetch_related("references", "aliases", "weaknesses") | |||
|
|||
def get_status(self, status): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method should be moved to VulnerabilityStatusType IMHO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some nits... please merge when you feel comfy!
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
91dd689
to
9d29cbd
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Fixes #1281