Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to CVSSv4 & SSVC and import the data using vulnrichment #1484

Merged
merged 2 commits into from
Aug 13, 2024
Merged

Add support to CVSSv4 & SSVC and import the data using vulnrichment #1484

merged 2 commits into from
Aug 13, 2024

Conversation

ziadhany
Copy link
Collaborator

@ziadhany ziadhany commented May 28, 2024 •
edited
Loading

issue: #1473
image

image

@ziadhany ziadhany marked this pull request as ready for review June 4, 2024 15:29
@ziadhany
Copy link
Collaborator Author

ziadhany commented Jun 4, 2024

@DennisClark @keshav-space @pombredanne @Hritik14

What vulnerability details would be most helpful for users to see within the CVSSv4 score?
https://www.first.org/cvss/calculator/4.0#CVSS:4.0/AV:N/AC:H/AT:P/PR:L/UI:P/VC:L/VI:H/VA:N/SC:L/SI:L/SA:N

@DennisClark
Copy link

The values provided in the grouping "Base Metrics" make sense here; I don't think we need more than those.

@ziadhany ziadhany changed the title Add support to CVSSv4 Add support to CVSSv4 & SSVC and import the data using vulnrichment Jun 24, 2024
@TG1999 TG1999 requested a review from keshav-space July 9, 2024 15:26
@ziadhany
Copy link
Collaborator Author

we should merge this pull request first : #1502

@keshav-space
Copy link
Member

we should merge this pull request first : #1502

Ack @ziadhany, will hold my reviews on this until #1502 is reviewed and merged.

@TG1999
Copy link
Contributor

TG1999 commented Jul 22, 2024

FYI #1502 is merged now

@ziadhany
Copy link
Collaborator Author

@TG1999 Wait, I need to add the ref type and CPES references. The code also still needs to be reviewed.

keshav-space
keshav-space requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziadhany, please see few nits below for your consideration and also update the branch with main.

vulnerabilities/importers/vulnrichment.py Outdated Show resolved Hide resolved
vulnerabilities/importers/vulnrichment.py Outdated Show resolved Hide resolved
vulnerabilities/importers/vulnrichment.py Show resolved Hide resolved
vulnerabilities/importers/vulnrichment.py Outdated Show resolved Hide resolved
vulnerabilities/importers/vulnrichment.py Show resolved Hide resolved
@ziadhany
Add the reference type to vulnrichment importer
3d15eaf 
Fix ssvc calculator bug
Add support for ref cpes & fix the tests
Ignore affected packages
Add SSVC calculator.
Add Support for SSVC.
Add vulnrichment importer.
Add support to CVSSv4

Signed-off-by: ziadhany <ziadhany2016@gmail.com>
keshav-space
keshav-space approved these changes Aug 13, 2024
View reviewed changes
Copy link
Member

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ziadhany, Looking Good!

@keshav-space keshav-space merged commit 8b6aaf5 into aboutcode-org:main Aug 13, 2024
7 checks passed
This was referenced Sep 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keshav-space keshav-space keshav-space approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ziadhany @DennisClark @keshav-space @TG1999