-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor GitlabDataSource to work with browser extension #1524
Refactor GitlabDataSource to work with browser extension #1524
Conversation
a3583f4
to
569e2f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michaelehab!
See some nits below and add DCO to your commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the test code, I read the contents of temp_vulntotal_gitlab_datasource folder, and this file is not included in the parsed_advisory-expected so the test was failing when we had it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #1524 (comment)
3761d09
to
f5a1163
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelehab You need to properly rebase or merge with the main branch without modifying the original commits. Let me know if you need help with this.
-Update Gitlab Datasource tests -Reorder test_parse_interesting_advisories test files -Format changed files with black -Merge fetch yml logic and update method doc Signed-off-by: Michael Ehab Mikhail <michael.ehab@hotmail.com>
e2298be
to
8bc0445
Compare
@keshav-space I squashed the changes and properly merged them with the main branch. Thank you! |
Signed-off-by: Michael Ehab Mikhail <michael.ehab@hotmail.com>
Signed-off-by: Michael Ehab Mikhail <michael.ehab@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @michaelehab, Looking good!
Fix #1523
This PR streamlines the GitLab datasource by eliminating the need for retrieving the repo subtree as a tar.gz file. Instead, it directly fetches YAML files from the repository. This change enhances compatibility, especially in Chrome extensions, and simplifies the codebase.
Changes Made:
Testing: