Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add on_failure to handle cleanup during pipeline failure #1651

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

keshav-space
Copy link
Member

@keshav-space keshav-space self-assigned this Nov 13, 2024
@TG1999
Copy link
Contributor

TG1999 commented Nov 13, 2024

@keshav-space can we have some sorts of tests, to check this ? If on_failure runs if any step fails ?

- Resolves #1639

Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
Signed-off-by: Keshav Priyadarshi <git@keshav.space>
@keshav-space keshav-space force-pushed the 1639-implement-on-failure branch from 6c5dd0e to 8f47de3 Compare November 14, 2024 10:43
@keshav-space
Copy link
Member Author

can we have some sorts of tests, to check this ? If on_failure runs if any step fails ?

@TG1999 done!

Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keshav-space keshav-space merged commit bac2274 into main Nov 14, 2024
9 checks passed
@keshav-space keshav-space deleted the 1639-implement-on-failure branch November 14, 2024 10:57
@pombredanne pombredanne added this to the v35.0.0 - 2-next milestone Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Some importers/improvers are sucking all disk space
3 participants