Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI #335

Merged
merged 11 commits into from
Feb 13, 2021
Merged

Improve UI #335

merged 11 commits into from
Feb 13, 2021

Conversation

sbs2001
Copy link
Collaborator

@sbs2001 sbs2001 commented Feb 3, 2021

Fixes #324, #320
Signed-off-by: Shivam Sandbhor shivam.sandbhor@gmail.com

@sbs2001 sbs2001 force-pushed the revisit_ui branch 2 times, most recently from 4694a2a to 7141ae6 Compare February 11, 2021 09:56
<a class ="navbar-item" href = "{% url 'vulnerability_create' %}">
Create
</a>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a minor nit but you want to keep your HTML properly formatted.
Here this would mean using consistent indentation and spaing (e.g. essentially as if it were Python)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, fixing it

Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
Signed-off-by: Shivam Sandbhor <shivam.sandbhor@gmail.com>
@sbs2001 sbs2001 merged commit 34d9a36 into aboutcode-org:main Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

web UI: The package name should not be mandatory
2 participants