Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanity Checks for redhat import response #387

Merged
merged 1 commit into from
Mar 19, 2021

Conversation

savish28
Copy link
Contributor

Issue Fix: #384.

Added Sanity checks for RedHat import failing.

@savish28 savish28 force-pushed the Issue#384 branch 3 times, most recently from ae4f9dd to 67f420c Compare March 18, 2021 15:32
@savish28
Copy link
Contributor Author

@sbs2001 PR up for review!

Copy link
Collaborator

@sbs2001 sbs2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@savish28 this looks good, see the nits I've left inline

value=bugzilla_severity_val,
)
if (
("bugs" in bugzilla_data)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be made more concise by using bugzilla_data.get("bugs")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbs2001 Done.

if (
("bugs" in bugzilla_data)
and len(bugzilla_data["bugs"])
and ("severity" in bugzilla_data["bugs"][0])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be made more concise by using bugzilla_data.get["bugs"][0].get("severity")

Signed-off-by: savish <savishbedi1@gmail.com>
Copy link
Collaborator

@sbs2001 sbs2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@sbs2001 sbs2001 merged commit 3d66b4e into aboutcode-org:main Mar 19, 2021
@savish28 savish28 deleted the Issue#384 branch March 19, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix KeyError in redhat importer
2 participants