Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate github importer to importer improver model #642

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Migrate github importer to importer improver model #642

merged 1 commit into from
Mar 25, 2022

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Mar 9, 2022

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

pombredanne
pombredanne requested changes Mar 10, 2022
View reviewed changes
Copy link
Collaborator

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few nits for your consideration

vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
vulnerabilities/importers/github.py Show resolved Hide resolved
vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
pombredanne
pombredanne approved these changes Mar 18, 2022
View reviewed changes
Copy link
Collaborator

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some nits for your review... Please fix the ones you think are essential and create issues for the ones that can wait and merge at you convenience.

vulnerabilities/helpers.py Outdated Show resolved Hide resolved
vulnerabilities/helpers.py Outdated Show resolved Hide resolved
vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
vulnerabilities/package_managers_2.py Outdated Show resolved Hide resolved
vulnerabilities/package_managers_2.py Outdated Show resolved Hide resolved
vulnerabilities/package_managers_2.py Outdated Show resolved Hide resolved
vulnerabilities/package_managers_2.py Show resolved Hide resolved
vulnerabilities/package_managers_2.py Outdated Show resolved Hide resolved
@TG1999 TG1999 changed the title migrate github importer to importer improver model Migrate github importer to importer improver model Mar 21, 2022
pombredanne
pombredanne reviewed Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few nits for your consisderation

vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
vulnerabilities/importers/github.py Show resolved Hide resolved
vulnerabilities/importers/github.py Outdated Show resolved Hide resolved
@TG1999 TG1999 mentioned this pull request Mar 25, 2022
Open
@TG1999
Reference: aboutcode-org#604
b6aad46 
Migrate github importer to importer-improver model

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 merged commit 33e083c into aboutcode-org:main Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pombredanne pombredanne pombredanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TG1999 @pombredanne