Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example importer and improver #672

Merged
merged 5 commits into from
Apr 12, 2022
Merged

Conversation

Hritik14
Copy link
Collaborator

@Hritik14 Hritik14 commented Apr 7, 2022

This is a dummy importer and improver that runs without network
connection only to test vulnerablecode framework

Signed-off-by: Hritik Vijay hritikxx8@gmail.com

@TG1999
Copy link
Contributor

TG1999 commented Apr 7, 2022

@Hritik14 Should we have some tests here for testing the example importer and improver ?

Copy link
Collaborator

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO this should not be registered as this creates junk data.

@Hritik14
Copy link
Collaborator Author

Hritik14 commented Apr 8, 2022

@TG1999 Good idea! Though, instead of testing this example importer / improver, I suppose I can test the entire framework using the example.

@pombredanne
Makes sense. The only way to run this example will now be using tests.

This is a dummy importer and improver that runs without network
connection only to test vulnerablecode framework

Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
This creates junk data. This importer should be run inside a test only

Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Following are tests associated with example importer and improver to
make sure the importer improver framework is working properly.

Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
It serves as a test data source and does not contribute any actual
data.

Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Copy link
Collaborator

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks

@pombredanne pombredanne merged commit 8a81708 into aboutcode-org:main Apr 12, 2022
@Hritik14 Hritik14 deleted the example branch April 19, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants