-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example importer and improver #672
Conversation
@Hritik14 Should we have some tests here for testing the example importer and improver ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO this should not be registered as this creates junk data.
@TG1999 Good idea! Though, instead of testing this example importer / improver, I suppose I can test the entire framework using the example. @pombredanne |
This is a dummy importer and improver that runs without network connection only to test vulnerablecode framework Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
This creates junk data. This importer should be run inside a test only Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
Following are tests associated with example importer and improver to make sure the importer improver framework is working properly. Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
It serves as a test data source and does not contribute any actual data. Signed-off-by: Hritik Vijay <hritikxx8@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks
This is a dummy importer and improver that runs without network
connection only to test vulnerablecode framework
Signed-off-by: Hritik Vijay hritikxx8@gmail.com