Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace filter in packages api #893

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

TG1999
Copy link
Contributor

@TG1999 TG1999 commented Sep 1, 2022

Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Copy link
Collaborator

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a just a minor nit for your review... I will merge as-is.. but let's make sure we always order fieds in the right purl field hierarchy

@@ -190,7 +190,15 @@ class PackageFilterSet(filters.FilterSet):

class Meta:
model = Package
fields = ["name", "type", "version", "subpath", "purl", "packagerelatedvulnerability__fix"]
fields = [
"name",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of fields should be ordered this way:

            "purl",
            "type",
            "namespace",
            "name",
            "version",
            "subpath",
            "packagerelatedvulnerability__fix",

@pombredanne pombredanne merged commit 25bea6b into aboutcode-org:main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants