Remove MyPy ignore directive

[DimitriPapadopoulos]

No description provided.

[abravalheri]

Thank you @DimitriPapadopoulos.

Do you know if there is an automatic way of removing directives previously needed by mypy? It could be integrated into the CI...

[DimitriPapadopoulos]

As a starting point, I suggest some of these Repo-Review suggestions (that's where this PR comes from). I can prepare a PR.

I have no experience with mypy-upgrade.

[abravalheri]

As a starting point, I suggest some of these Repo-Review suggestions (that's where this PR comes from). I can prepare a PR.

I think some of these are fine, but others might too much for this repo (like prettier or custom pre-commit message).

Does mypy-upgrade can get rid of type: ignore comments that become obsolete with newer versions of mypy?

[DimitriPapadopoulos]

I think some of these are fine, but others might too much for this repo (like prettier or custom pre-commit message).

I was thinking of the settings related to MyPy only, and then only those that aren't too invasive. See #191.

Does mypy-upgrade can get rid of type: ignore comments that become obsolete with newer versions of mypy?

Yes, according to Features (but again I don't have any experience with it):

• Removal of unused type: ignore comments
• Replacement of blanket type: ignore comments with error code-specific comments
• Support for suppressing multiple mypy errors per-line
• Preservation of existing in-line comments
• Optional inclusion of mypy error description messages
• Selective suppression of type errors by file, directory, package, module, or mypy error codes

[DimitriPapadopoulos]

Actually, I wonder whether repo-review uses mypy-upgrade internally, or if they share a common base. Indeed, they report the exact same issues.

[henryiii]

sp-repo-review only looks at configuration files. Generally repo-review plugins are recommended to process configuration files, and aren't encouraged to look at source files. (The WebAssembly version has to fetch each file, so limiting access is encouraged).

[DimitriPapadopoulos]

Indeed, I got it all mixed up. I meant that the MyPy changes suggested by repo-review end up in the same suggestions as mypy-update. So the additional MyPy options seem equivalent to mypy-update.