Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compilation of generic byteswap routines #201

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Fix compilation of generic byteswap routines #201

merged 1 commit into from
Oct 30, 2018

Conversation

ccawley2011
Copy link
Contributor

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

@ccawley2011
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

mbxx
mbxx approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@mbxx mbxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! That's an embarrassing gap in our test coverage.

@mattcalabrese-google mattcalabrese-google merged commit 0117457 into abseil:master Oct 30, 2018
@ccawley2011 ccawley2011 deleted the fix-byteswap branch October 30, 2018 15:22
absl-federation-github pushed a commit that referenced this pull request Dec 17, 2018
@ahedberg
Creation of LTS branch "lts_2018_12_18"
fcb1045 
  - 44b0faf Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 926bfeb Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 13327de Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 3088e76 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f6ae816 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a06c4a1 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 7b46e1d Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 070f6e4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 7990fd4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f951790 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - cc8dcd3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a705aa7 Merge pull request #194 from Mizux/windows by Xiaoyi Zhang <zhangxy988@gmail.com>
  - a4c3fff Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0117457 Merge pull request #201 from ccawley2011/fix-byteswap by Matt Calabrese <38107210+mattcalabrese-google@users.noreply.github.com>
  - f86f941 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 94c298e Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0884a6a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - c16d555 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 45221cc Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 2019e17 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5b70a89 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a00bdd1 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f340f77 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 445998d Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - e821380 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f21d187 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5441bbe Fix code snippet in comment (#174) by Loo Rong Jie <loorongjie@gmail.com>
  - 5aae0cf Fix CMake build (#173) by Stephan Dollberg <stephan.dollberg@gmail.com>
  - 48cd2c3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - e291c27 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - e01d955 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 8ff1374 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0245191 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 921fd5c Merge pull request #166 from rongjiecomputer/cmake-test by Gennadiy Civil <gennadiycivil@users.noreply.github.com>
  - fb46222 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - c075ad3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 0f4bc96 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 6c7e5ff Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - d6df769 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 28080f5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 9c987f4 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 5e7d459 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - bed5bd6 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - fefc836 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - d8cfe9f Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - ad5c960 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 86f0fe9 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f0f15c2 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 29ff6d4 Removed "warning treated as error" flag from MSVC (#153) by vocaviking <vocaviking@users.noreply.github.com>
  - 083d04d Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - bea85b5 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 8f96be6 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 92e07e5 Merge pull request #152 from clnperez/fix-multi-defines-p... by Derek Mauro <761129+derekmauro@users.noreply.github.com>
  - 2125e64 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 9acad86 Merge pull request #150 from OlafvdSpek/patch-2 by Jonathan Cohen <cohenjon@google.com>
  - c2e00d3 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 9e06068 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 7aa411c Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 2c5af55 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 44aa275 Merge pull request #143 from rongjiecomputer/kernel by Xiaoyi Zhang <zhangxy988@gmail.com>
  - 42f22a2 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - b973bc5 Merge pull request #139 from siepkes/smartos-support by ahedberg <ahedberg@google.com>
  - e0def74 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - f826f1d Merge pull request #138 from edbaunton/remove-deprecated-... by ahedberg <ahedberg@google.com>
  - 7b50a4a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - a5030ca Merge pull request #144 from rongjiecomputer/winsock2 by Xiaoyi Zhang <zhangxy988@gmail.com>
  - 0268795 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 8f612eb Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 134496a Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - ba8d6cf Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - be1e84b Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 16ac2ec Merge pull request #134 from rongjiecomputer/cmake by Alex Strelnikov <strel@google.com>
  - 7efd8dc Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 87a4c07 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>
  - 4491d60 Export of internal Abseil changes. by Abseil Team <absl-team@google.com>

GitOrigin-RevId: 44b0faf
Change-Id: I2c427b5b41b2d34101922048b00f3d9dafcb498d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbxx mbxx mbxx approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ccawley2011 @googlebot @mbxx @kokoro-team @mattcalabrese-google