Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure interface nullable types can be implemented by non-nullable types #1009

Merged
merged 1 commit into from
Dec 25, 2020
Merged

Ensure interface nullable types can be implemented by non-nullable types #1009

merged 1 commit into from
Dec 25, 2020

Commits on Dec 25, 2020

  1. Ensure interface nullable types can be implemented by non-nullable types 

    Fixes absinthe-graphql#987

Two cases are added to the schema:
 * a simple nullable interface -> non-nullable implementor.
 * a nullable list -> with implementors `list_of(non_null(type))` and
   `non_null(list_of(non_null(type)))`.

From my reading of the spec these should all validate.

https://spec.graphql.org/draft/#IsValidImplementationFieldType()

I did find that it is not validated whether the object implements
the field's arguments. Also that the object does not implement
extra non-nullable arguments that are not specified in the interface,
this is not allowed. I'll create an issue for this.
    @maartenvanvliet
    maartenvanvliet committed Dec 25, 2020
    Configuration menu
    Copy the full SHA
    670a05a View commit details
    Browse the repository at this point in the history