Validate type references for invalid wrapped types #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some places we were not checking for invalid wrapped types (non-null/list). E.g. ```elixir union :my_union do types [:boolean, list_of(:id)] end ``` Or when using `import_fields` or `interface` with a wrapped type. This PR adds the missing checks in the TypeReferencesExist phase. All cases where a wrapped type is invalid are now caught in this phase. What still needs to be tackled is whether the types passed in are valid for that case. A union's types can only consist of object types, interfaces can only refer to interface definitions etc. This could be done in a separate phase. Some of this work is (incidentally) tackled by other phases but I think it makes sense to group this. Fixes absinthe-graphql#1048
benwilson512
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some places we were not checking for invalid wrapped types (non-null/list). E.g.
Or when using
import_fieldsorinterfacewith a wrapped type.This PR adds the missing checks in the TypeReferencesExist phase. All cases where a wrapped type is invalid are now caught in this phase.
What still needs to be tackled is whether the types passed in are valid for that case. A union's types can only consist of object types, interfaces can only refer to interface definitions etc. This could be done in a separate phase. Some of this work is (incidentally) tackled by other phases but I think it makes sense to group this.
Fixes #1048