Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type extensions objects can be empty #1228

Conversation

maartenvanvliet
Copy link
Contributor

See the spec https://spec.graphql.org/October2021/#sec-Object-Extensions

an object extending another object can be empty. This is useful for
adding directives to an object without adding any fields.

It came up in a slack conversation that this was an issue

See the spec https://spec.graphql.org/October2021/#sec-Object-Extensions

an object extending another object can be empty. This is useful for
adding directives to an object without adding any fields.

It came up in a slack conversation that this was an issue
Copy link
Contributor

@kdawgwilk kdawgwilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@benwilson512 benwilson512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@benwilson512 benwilson512 merged commit 8d571bf into absinthe-graphql:master Feb 10, 2023
@maartenvanvliet maartenvanvliet deleted the type-extensions-objects-can-be-empty branch February 10, 2023 21:19
@maartenvanvliet
Copy link
Contributor Author

thx! 🎉

@rewritten
Copy link
Contributor

👏 👏 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants