Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow config/2 to send errors in spec compliant format #1341

Merged
merged 3 commits into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/absinthe/phase/document/result.ex
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,15 @@ defmodule Absinthe.Phase.Document.Result do
defp field_name(%{alias: name}), do: name
defp field_name(%{name: name}), do: name

defp format_error(%Phase.Error{message: %{message: _message} = error_object} = error, _opts) do
if Enum.empty?(error.locations) do
error_object
else
locations = Enum.flat_map(error.locations, &format_location/1)
Map.put_new(error_object, :locations, locations)
end
end

defp format_error(%Phase.Error{locations: []} = error, opts) do
error_object = %{message: error.message}

Expand Down
42 changes: 42 additions & 0 deletions test/absinthe/execution/subscription_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,18 @@ defmodule Absinthe.Execution.SubscriptionTest do
{:ok, topic: "*", context_id: "*", document_id: op_name}
end
end

field :config_error, :string do
config fn _, _ ->
{:error, "failed"}
end
end

field :config_error_with_map, :string do
config fn _, _ ->
{:error, %{message: "failed", extensions: %{code: "FAILED"}}}
end
end
end

mutation do
Expand Down Expand Up @@ -617,6 +629,36 @@ defmodule Absinthe.Execution.SubscriptionTest do
assert_receive(:batch_get_group)
end

@query """
subscription Example {
configError
}
"""
test "config errors" do
assert {:ok, %{errors: [%{message: "failed"}]}} =
run_subscription(
@query,
Schema,
variables: %{},
context: %{pubsub: PubSub}
)
end

@query """
subscription Example {
configErrorWithMap
}
"""
test "config errors with a map" do
assert {:ok, %{errors: [%{message: "failed", extensions: %{code: "FAILED"}}]}} =
run_subscription(
@query,
Schema,
variables: %{},
context: %{pubsub: PubSub}
)
end

describe "subscription_ids" do
@query """
subscription {
Expand Down
Loading