Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to set default query #197

Merged
merged 3 commits into from
Aug 12, 2019
Merged

allow to set default query #197

merged 3 commits into from
Aug 12, 2019

Conversation

ayrat555
Copy link
Contributor

Changelog:

  • allow passing default_query parameter to advanced GraphiQL interface

@ayrat555 ayrat555 mentioned this pull request Feb 12, 2019
Merged
@ayrat555
Copy link
Contributor Author

@benwilson512 @bruce can you take a look when you have time? thanks

@ayrat555
Copy link
Contributor Author

@benwilson512 ping

@ayrat555
Copy link
Contributor Author

@bruce you're my only hope!

@axelson
Copy link

axelson commented Mar 5, 2019

@ayrat555 just curious, what is the point of passing a default_query? i.e. what does it do? What is a typical use-case. Also I would think that it would be best to support the basic graphiql as well as advanced.

@ayrat555
Copy link
Contributor Author

ayrat555 commented Mar 6, 2019

@axelson to show it as an example in the graphiql interface. playground does not support passing default query. There is an issue graphql/graphql-playground#301

@benwilson512
Copy link
Contributor

Hi @ayrat555, please use mix format so that the CI passes.

@ayrat555 ayrat555 force-pushed the ab-allow-to-set-default-query branch from d4320bd to e38ddbe Compare August 7, 2019 13:22
@ayrat555
Copy link
Contributor Author

ayrat555 commented Aug 7, 2019

@benwilson512 done

@ayrat555
Copy link
Contributor Author

@benwilson512 will you merge it?

@benwilson512 benwilson512 merged commit 91f24da into absinthe-graphql:master Aug 12, 2019
@ayrat555
Copy link
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benwilson512 benwilson512 benwilson512 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayrat555 @axelson @benwilson512