-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message UUID so that we can follow e2e flow #399
Comments
@srados please take this issue with high priority, so that we can release |
Sorry - didn't find this issue when I searched. using a uuid would adhere to the similar opentracing format, so that would be perfect: https://github.com/opentracing/specification/blob/master/rfc/trace_identifiers.md#trace-context-http-headers Similar to opentracing, I would ask that the ID be able to be set as an input field (or header?) so that correlation could accomplished across upstream systems. |
@srados while on this, please take a look at Jaeger as well - there is go-kit support already: https://github.com/go-kit/kit/tree/master/tracing#opentracing We should use this opportunity to align as much as possible to https://opentracing.io/specification/ and make implementation future proof. Also, please investigate if something other should be changed/added to adhere to the standard. |
@nwest1 header would be ok for HTTP and gRPC however, we also have MQTT and WS that need to receive the correlation ID from upstream. What is your opinion on that? |
PoC with opentracing integration is in WIP. Moving this to |
Add UUID to each message that flows though Mainflux so we can log and follow the flow.
For RewMessage
UUID
field with be UUIDv4. For MessageUUID
can be<parent_uuid>.<local_increment>
format - for example<parent_uuid>.0
,<parent_uuid>.1
and so on - because RawMessage is de-aggregated locally innormalizer
.The text was updated successfully, but these errors were encountered: