MF-399 - Add open tracing support #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #782 +/- ##
=========================================
Coverage ? 85.51%
=========================================
Files ? 72
Lines ? 4624
Branches ? 0
=========================================
Hits ? 3954
Misses ? 446
Partials ? 224
Continue to review full report at Codecov.
|
drasko
reviewed
Jul 14, 2019
| @@ -1,5 +1,5 @@ | |||
| // | |||
There was a problem hiding this comment.
I would suggest dropping a year from headers and contracting them to something like this:
// Copyright (c) Mainflux
// SPDX-License-Identifier: Apache-2.0
There was a problem hiding this comment.
@drasko can we do this in another PR, this one is already huge?
| @@ -1,5 +1,5 @@ | |||
| // | |||
| @@ -1,5 +1,5 @@ | |||
| // | |||
anovakovic01
force-pushed
the
MF-399
branch
2 times, most recently
from
8411f49
to
a43d385
Compare
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
|
LGTM |
mteodor
approved these changes
Jul 18, 2019
nmarcetic
approved these changes
Jul 18, 2019
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Add open tracing dependencies Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Add open tracing to users service Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Add open tracing to the things service Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Add open tracing to the http adapter Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Add open tracing to the ws adapter Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Add open tracing to the CoAP adapter Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Update LoRa adapter in accordance with changes Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Update SDK tests in accordance with changes Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Update bootstrap service in accordance with changes Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Update reader services with accordance with changes Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Update .env and docker-compose file Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Add jaeger and timeout env vars Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Fix broken test for can access by id endpoint Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Update deps with proto empty package Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds base open tracing support to
usersandthingsservice.Which issue(s) does this PR fix/relate to?
Resolves #399.
List any changes that modify/break current functionality
There are no such changes.
Have you included tests for your changes?
Existing tests are updated.
Did you document any new/modified functionality?
README.mddoc is updated with new env vars.Notes
Open tracing support can be improved by adding tags to the existing spans. Also, open tracing support should be added to bootstrap service. One of the next steps would also be to add tracing of messages that are passing through NATS.