MF-1006 - Password recovery endpoint is not working #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
blokovi
approved these changes
Jan 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #1007 +/- ##
==========================================
+ Coverage 79.75% 79.77% +0.01%
==========================================
Files 95 95
Lines 6551 6545 -6
==========================================
- Hits 5225 5221 -4
Misses 1012 1012
+ Partials 314 312 -2
Continue to review full report at Codecov.
|
nmarcetic
reviewed
Jan 16, 2020
| issuerName = "mainflux.authn" | ||
| loginDuration = 10 * time.Hour | ||
| recoveryDuration = 5 * time.Minute | ||
| issuerName = "mainflux.authn" | ||
| ) |
There was a problem hiding this comment.
Can we use this as default values and provide env variables? IMHO 5min is to short for recovery token, I would set at least 15+ min
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Dušan Borovčanin <dusan.borovcanin@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This pull request fixes password recovery.
Which issue(s) does this PR fix/relate to?
Fixes #1006.
List any changes that modify/break current functionality
There are no such changes.
Have you included tests for your changes?
Yes.
Did you document any new/modified functionality?
Yes.