Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE- Fixed docs instructions in README #1010

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

nmarcetic
Copy link
Collaborator

Signed-off-by: Nikola Marcetic n.marcetic86@gmail.com

What does this do?

Fix docs build instructions in README

Which issue(s) does this PR fix/relate to?

NA

List any changes that modify/break current functionality

NA

Have you included tests for your changes?

NO

Did you document any new/modified functionality?

NO

Notes

NA

Signed-off-by: Nikola Marcetic <n.marcetic86@gmail.com>
@nmarcetic nmarcetic requested a review from a team as a code owner January 17, 2020 13:25
@codecov-io
Copy link

Codecov Report

Merging #1010 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1010      +/-   ##
=========================================
+ Coverage   79.77%   79.8%   +0.03%     
=========================================
  Files          95      95              
  Lines        6545    6545              
=========================================
+ Hits         5221    5223       +2     
+ Misses       1012    1010       -2     
  Partials      312     312
Impacted Files Coverage Δ
things/service.go 90.44% <0%> (+1.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update decfae9...a9caad1. Read the comment docs.

Copy link
Contributor

@manuio manuio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio manuio merged commit 5714a6d into absmach:master Jan 17, 2020
@nmarcetic nmarcetic deleted the housecleaning branch January 28, 2020 13:56
manuio pushed a commit that referenced this pull request Oct 12, 2020
Signed-off-by: Nikola Marcetic <n.marcetic86@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants