NOISSUE - Fix twins update revision counter #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
nmarcetic
approved these changes
Jan 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #1011 +/- ##
==========================================
- Coverage 79.77% 79.74% -0.03%
==========================================
Files 95 95
Lines 6545 6552 +7
==========================================
+ Hits 5221 5225 +4
- Misses 1012 1014 +2
- Partials 312 313 +1
Continue to review full report at Codecov.
|
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darko Draskovic darko.draskovic@gmail.com
What does this do?
Fix twins update revision bump when the empty update request is sent.
Fix twins metadata update: metadata did not get updated.
Adds json hints for Attributes and Definition.