NOISSUE Fix obsolete attribute persistance #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1018 +/- ##
==========================================
- Coverage 79.74% 79.69% -0.05%
==========================================
Files 95 95
Lines 6552 6556 +4
==========================================
Hits 5225 5225
- Misses 1014 1018 +4
Partials 313 313
Continue to review full report at Codecov.
|
drasko
requested changes
Jan 27, 2020
Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Fix obsolete attribute update Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com> * Inlined map key presence check Signed-off-by: Darko Draskovic <darko.draskovic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Darko Draskovic darko.draskovic@gmail.com
What does this do?
Fix the problem with state persisting the attribute corresponding to the previous definition.