NOISSUE - Fix minimal password length #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase minimum password length to 8. Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
nmarcetic
approved these changes
Jan 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #1023 +/- ##
==========================================
+ Coverage 79.69% 79.72% +0.02%
==========================================
Files 95 95
Lines 6556 6564 +8
==========================================
+ Hits 5225 5233 +8
- Misses 1018 1019 +1
+ Partials 313 312 -1
Continue to review full report at Codecov.
|
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
* Fix minimum password length Increase minimum password length to 8. Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Update tests with valid password length Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com> * Update minimal pass length in the docs Signed-off-by: Aleksandar Novakovic <anovakovic01@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Updates minimal password length to 8, and adds password length validation to the users API.
Which issue(s) does this PR fix/relate to?
There is no issue for this PR.
List any changes that modify/break current functionality
Now it's required that users use passwords that are at least 8 characters long.
Have you included tests for your changes?
I've updated an existing tests.
Did you document any new/modified functionality?
I've updated existing swagger for
usersservice.