Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix connect CLI command and remove ConnectThing func from SDK #1051

Merged
merged 3 commits into from
Mar 3, 2020
Merged

Conversation

manuio
Copy link
Contributor

@manuio manuio commented Mar 2, 2020

Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio requested a review from a team as a code owner March 2, 2020 17:09
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #1051 into master will increase coverage by 0.02%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1051      +/-   ##
==========================================
+ Coverage      79%   79.03%   +0.02%     
==========================================
  Files          95       95              
  Lines        6622     6610      -12     
==========================================
- Hits         5232     5224       -8     
+ Misses       1078     1076       -2     
+ Partials      312      310       -2
Impacted Files Coverage Δ
sdk/go/sdk.go 96.87% <ø> (ø) ⬆️
sdk/go/things.go 64.48% <ø> (-1.04%) ⬇️
bootstrap/service.go 83.09% <75%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcba41e...8f290eb. Read the comment docs.

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio manuio merged commit 9e2bb49 into absmach:master Mar 3, 2020
@manuio manuio deleted the cli branch March 3, 2020 09:58
manuio added a commit that referenced this pull request Oct 12, 2020
…DK (#1051)

* NOISSUE - Fix connect CLI command and remove ConnectThing func from SDK

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>

* Rm ConnectThing from bootstrap

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants