Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Fix SDK Messages response #1064

Merged
merged 1 commit into from
Mar 7, 2020
Merged

NOISSUE - Fix SDK Messages response #1064

merged 1 commit into from
Mar 7, 2020

Conversation

manuio
Copy link
Contributor

@manuio manuio commented Mar 6, 2020

Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com

Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
@manuio manuio requested a review from a team as a code owner March 6, 2020 12:40
@codecov-io
Copy link

Codecov Report

Merging #1064 into master will decrease coverage by 0.03%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1064      +/-   ##
==========================================
- Coverage   78.32%   78.28%   -0.04%     
==========================================
  Files          95       95              
  Lines        6670     6645      -25     
==========================================
- Hits         5224     5202      -22     
+ Misses       1136     1133       -3     
  Partials      310      310
Impacted Files Coverage Δ
sdk/go/sdk.go 96.87% <ø> (ø) ⬆️
sdk/go/message.go 38.59% <0%> (+3.11%) ⬆️
sdk/go/channels.go 60% <66.66%> (-2.29%) ⬇️
sdk/go/things.go 62.74% <66.66%> (-1.75%) ⬇️
things/service.go 88.97% <0%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d587921...13102fa. Read the comment docs.

Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuio manuio merged commit 6e4e5b3 into absmach:master Mar 7, 2020
@manuio manuio deleted the sdk branch March 7, 2020 10:57
manuio added a commit that referenced this pull request Oct 12, 2020
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants