NOISSUE - Fix opc-ua message type handling #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
drasko
requested changes
Mar 11, 2020
opcua/api/transport.go
Outdated
| @@ -24,6 +24,9 @@ const ( | |||
|
|
|||
| defOffset = 0 | |||
| defLimit = 10 | |||
|
|
|||
| defNamespace = "ns=0" | |||
| defIdentifier = "i=84" | |||
There was a problem hiding this comment.
Please leave a comment next to these magic numbers.
opcua/gopcua/browser.go
Outdated
| @@ -14,7 +14,7 @@ import ( | |||
| "github.com/mainflux/mainflux/opcua" | |||
| ) | |||
|
|
|||
| const maxChildrens = 7 | |||
| const maxChildrens = 5 | |||
There was a problem hiding this comment.
Same here - why 5, some comment please
There was a problem hiding this comment.
I can't really explain why 5 or 7... It's just to try to make this faster but it depends on the server...
There was a problem hiding this comment.
We will remove this and change the architecture. No need for now
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1071 +/- ##
==========================================
- Coverage 78.27% 78.24% -0.04%
==========================================
Files 95 95
Lines 6648 6648
==========================================
- Hits 5204 5202 -2
- Misses 1134 1136 +2
Partials 310 310
Continue to review full report at Codecov.
|
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
mteodor
reviewed
Mar 12, 2020
opcua/gopcua/browser.go
Outdated
| nodes = append(nodes, children...) | ||
| } | ||
| return nil | ||
| bc, err := broseChildren(n, def.Path, level, id.HasComponent) |
opcua/gopcua/browser.go
Outdated
| @@ -14,7 +14,7 @@ import ( | |||
| "github.com/mainflux/mainflux/opcua" | |||
| ) | |||
|
|
|||
| const maxChildrens = 7 | |||
| const maxChildrens = 5 | |||
Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
manuio
added a commit
that referenced
this pull request
Oct 12, 2020
* NOISSUE - Fix opc-ua message type handling Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Add comments Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix reviews Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Fix typo Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com> * Return error Signed-off-by: Manuel Imperiale <manuel.imperiale@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Manuel Imperiale manuel.imperiale@gmail.com